Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: sdk/lib/developer/developer.dart

Issue 1247803002: Refactor dart:developer log to use named parameters (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/developer_patch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/developer/developer.dart
diff --git a/sdk/lib/developer/developer.dart b/sdk/lib/developer/developer.dart
index 04a3b0053516c8682c14e301ba517965451e970c..06c980e7e929f833b7d6997e137103d7ddac3ef4 100644
--- a/sdk/lib/developer/developer.dart
+++ b/sdk/lib/developer/developer.dart
@@ -43,23 +43,11 @@ external inspect(object);
/// [zone] (optional) the zone where the log was emitted
/// [error] (optional) an error object associated with this log event.
/// [stackTrace] (optional) a stack trace associated with this log event.
-external log(int sequenceNumber,
- int millisecondsSinceEpoch,
- int level,
- String name,
- String message,
- [Zone zone,
+external log({int sequenceNumber,
+ int millisecondsSinceEpoch,
+ int level,
+ String name,
+ String message,
+ Zone zone,
Object error,
- StackTrace stackTrace]);
-
-/// Emit a log event for a a [LogRecord] from the [logging] package.
-void logOnRecord(dynamic logRecord) {
- log(logRecord.sequenceNumber,
- logRecord.time.millisecondsSinceEpoch,
- logRecord.level.value,
- logRecord.loggerName,
- logRecord.message,
- null,
- logRecord.error,
- logRecord.stackTrace);
-}
+ StackTrace stackTrace});
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/developer_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698