Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: Source/bindings/tests/idls/TestObject.idl

Issue 124763002: Support IDL attributes limited to only known values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/idls/TestObject.idl
diff --git a/Source/bindings/tests/idls/TestObject.idl b/Source/bindings/tests/idls/TestObject.idl
index 984f9baa44c8c24fdfb813578b36955d34642d82..d7893b4a00d904d91bf82661b63d63cac74afef2 100644
--- a/Source/bindings/tests/idls/TestObject.idl
+++ b/Source/bindings/tests/idls/TestObject.idl
@@ -74,6 +74,9 @@ callback TestCallbackFunction = void (TestEnumType formal1, TestObject formal2);
[Reflect=customContentBooleanAttr] attribute boolean reflectedCustomBooleanAttr;
[Reflect=customContentURLAttr, TreatNullAs=NullString, URL] attribute DOMString reflectedCustomURLAttr;
[Reflect] attribute SVGAnimatedString animatedReflectedAttribute;
+ [Reflect, ReflectOnly=unique] attribute DOMString limitedToOnlyOneAttribute;
+ [Reflect, ReflectOnly=Per Paal Espen] attribute DOMString limitedToOnlyAttribute;
haraken 2014/01/06 06:23:53 Shall we use ReflectOnly=Per|Paal|Pspen instead of
sof 2014/01/06 06:40:51 I thought I could from reading the IDLExtendedAttr
Nils Barth (inactive) 2014/01/06 06:42:51 ?? To agree with haraken, we can't use spaces here
Nils Barth (inactive) 2014/01/06 07:12:49 Thanks for catching this; this is a bug, which I'v
sof 2014/01/06 10:59:19 Thanks; rebased this CL on top of it + switched to
+ [Reflect=Other, ReflectOnly=Value1 Value2] attribute DOMString limitedToOnlyOtherAttribute;
// TypedArray attribute
attribute Float32Array typedArrayAttr;

Powered by Google App Engine
This is Rietveld 408576698