Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1247533003: Revert of Add missing dependencies. (Closed)

Created:
5 years, 5 months ago by Michael Courage
Modified:
5 years, 5 months ago
Reviewers:
danakj, marcheu, jam, M-A Ruel
CC:
chromium-reviews, extensions-reviews_chromium.org, Matt Giuca, tapted, tfarina, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add missing dependencies. (patchset #7 id:120001 of https://codereview.chromium.org/1242323004/) Reason for revert: It looks to me like this broke the iOS_Device builder starting at https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/14003, despite the green trybots. === BUILD TARGET osmesa OF PROJECT mesa WITH CONFIGURATION Release === Check dependencies CodeSign error: code signing is required for product type 'Dynamic Library' in SDK 'iOS 8.3' ** BUILD FAILED ** The following build commands failed: Check dependencies (1 failure) Original issue's description: > Add missing runtime dependencies to *_run targets. > > A follow up CL removes dynamic libraries that would be fetched automatically via > implicit dependencies. The target hierarchy needs to be there in the first > place for this to work. > > R=jam@chromium.org > BUG=98637 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/d7b8df80cd5ce2a882bbf35482dc21cee34934f9 > Cr-Commit-Position: refs/heads/master@{#339994} TBR=jam@chromium.org,danakj@chromium.org,marcheu@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/dff351a5527dd5cf81b4740e4caf63e84a3e9d2f Cr-Commit-Position: refs/heads/master@{#340015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M cc/cc_tests.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +1 line, -4 lines 0 comments Download
M extensions/extensions_tests.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Courage
Created Revert of Add missing dependencies.
5 years, 5 months ago (2015-07-23 00:49:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247533003/1
5 years, 5 months ago (2015-07-23 00:50:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 00:51:26 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 00:52:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dff351a5527dd5cf81b4740e4caf63e84a3e9d2f
Cr-Commit-Position: refs/heads/master@{#340015}

Powered by Google App Engine
This is Rietveld 408576698