DescriptionRevert of Add missing dependencies. (patchset #7 id:120001 of https://codereview.chromium.org/1242323004/)
Reason for revert:
It looks to me like this broke the iOS_Device builder starting at https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/14003, despite the green trybots.
=== BUILD TARGET osmesa OF PROJECT mesa WITH CONFIGURATION Release ===
Check dependencies
CodeSign error: code signing is required for product type 'Dynamic Library' in SDK 'iOS 8.3'
** BUILD FAILED **
The following build commands failed:
Check dependencies
(1 failure)
Original issue's description:
> Add missing runtime dependencies to *_run targets.
>
> A follow up CL removes dynamic libraries that would be fetched automatically via
> implicit dependencies. The target hierarchy needs to be there in the first
> place for this to work.
>
> R=jam@chromium.org
> BUG=98637
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/d7b8df80cd5ce2a882bbf35482dc21cee34934f9
> Cr-Commit-Position: refs/heads/master@{#339994}
TBR=jam@chromium.org,danakj@chromium.org,marcheu@chromium.org,maruel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637
Committed: https://crrev.com/dff351a5527dd5cf81b4740e4caf63e84a3e9d2f
Cr-Commit-Position: refs/heads/master@{#340015}
Patch Set 1 #
Created: 5 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|