Issue 1247493002: Modify include paths to build with Windows SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1247493002: Modify include paths to build with Windows SDK (Closed)

Created:
5 years, 5 months ago by brucedawson

Modified:
5 years, 2 months ago

Reviewers:
scottmg

CC:
chromium-reviews, jschuh

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Modify paths so that we build with the Windows 10 SDK, RTM version (10.0.10240.0). For testing purposes: do not submit This is sufficient to get Chrome to use the Windows 10 SDK if you have it installed. It is used in conjunction with: set DEPOT_TOOLS_WIN_TOOLCHAIN=0 set GYP_MSVS_VERSION=2015 It does not update the lib search paths BUG=491424 R=scottmg@chromium.org

Patch Set 1 #

Patch Set 2 : Changed SDK path to 10166 #

Patch Set 3 : Update to final Windows 10 SDK version #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	build/common.gypi	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

brucedawson

5 years, 5 months ago (2015-07-20 20:36:07 UTC) #1

This is an FYI

This isn't intended for submission. I haven't actually investigated what it
takes to *actually* roll to a new SDK.

But, with the 10.0.10158.0 SDK installed locally and this patch applied and VS
2015 RTM installed and the very latest code (circa ~1:30 on 7/20/2015) pulled
and with these environment variables set:

set GYP_MSVS_VERSION=2015
set DEPOT_TOOLS_WIN_TOOLCHAIN=0

the 'chrome' target builds and runs successfully. The other targets are not yet
all building.

Expand Messages | Collapse Messages