Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1247363002: Remove RestartFrame from live edit API (Closed)

Created:
5 years, 5 months ago by yurys
Modified:
5 years, 5 months ago
Reviewers:
dgozman, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove RestartFrame from live edit API There is already non-throwing version FrameMirror.restart and RestartFrame in the livedit-debugger.js just adds a throwing wrapper around it. Also NEEDS_STEP_IN_PROPERTY_NAME was removed, the client code can decide based on the stack_modified field if "step in" is required. Chromium side was fixed in https://codereview.chromium.org/1249013002/ BUG=None LOG=N Committed: https://crrev.com/84f8e1af76e06f645256055387cdd2f5902917cf Cr-Commit-Position: refs/heads/master@{#29797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M src/liveedit-debugger.js View 3 chunks +2 lines, -20 lines 0 comments Download
M test/mjsunit/debug-liveedit-restart-frame.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yurys
5 years, 5 months ago (2015-07-22 15:20:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247363002/1
5 years, 5 months ago (2015-07-22 15:20:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-22 18:27:16 UTC) #6
Yang
On 2015/07/22 18:27:16, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 5 months ago (2015-07-23 06:11:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247363002/1
5 years, 5 months ago (2015-07-23 07:45:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 07:46:54 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 07:47:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84f8e1af76e06f645256055387cdd2f5902917cf
Cr-Commit-Position: refs/heads/master@{#29797}

Powered by Google App Engine
This is Rietveld 408576698