Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1953)

Unified Diff: src/liveedit-debugger.js

Issue 1247363002: Remove RestartFrame from live edit API (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/debug-liveedit-restart-frame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/liveedit-debugger.js
diff --git a/src/liveedit-debugger.js b/src/liveedit-debugger.js
index eaa23834c964d22737de4b954a4142edd53a9cc9..af7712d8013522e0a5546d4a3324f6669434b35e 100644
--- a/src/liveedit-debugger.js
+++ b/src/liveedit-debugger.js
@@ -27,8 +27,6 @@ Debug.LiveEdit = new function() {
// Forward declaration for minifier.
var FunctionStatus;
- var NEEDS_STEP_IN_PROPERTY_NAME = "stack_update_needs_step_in";
-
// Applies the change to the script.
// The change is in form of list of chunks encoded in a single array as
// a series of triplets (pos1_start, pos1_end, pos2_end)
@@ -149,12 +147,9 @@ Debug.LiveEdit = new function() {
var dropped_functions_number =
CheckStackActivations(replaced_function_infos, change_log);
- preview_description.stack_modified = dropped_functions_number != 0;
-
// Our current implementation requires client to manually issue "step in"
- // command for correct stack state.
- preview_description[NEEDS_STEP_IN_PROPERTY_NAME] =
- preview_description.stack_modified;
+ // command for correct stack state if the stack was modified.
+ preview_description.stack_modified = dropped_functions_number != 0;
// Start with breakpoints. Convert their line/column positions and
// temporary remove.
@@ -1103,19 +1098,6 @@ Debug.LiveEdit = new function() {
return ProcessOldNode(old_code_tree);
}
- // Restarts call frame and returns value similar to what LiveEdit returns.
- function RestartFrame(frame_mirror) {
- var result = frame_mirror.restart();
- if (IS_STRING(result)) {
- throw new Failure("Failed to restart frame: " + result);
- }
- var result = {};
- result[NEEDS_STEP_IN_PROPERTY_NAME] = true;
- return result;
- }
- // Function is public.
- this.RestartFrame = RestartFrame;
-
// Functions are public for tests.
this.TestApi = {
PosTranslator: PosTranslator,
« no previous file with comments | « no previous file | test/mjsunit/debug-liveedit-restart-frame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698