Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: Source/modules/app_banner/AppBannerPromptResult.h

Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Replace typedef with using as per style guide Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/app_banner/AppBannerPromptResult.h
diff --git a/Source/modules/app_banner/AppBannerPromptResult.h b/Source/modules/app_banner/AppBannerPromptResult.h
index a949c7d086ae61e457d92f1a613c8417b724ee16..e160c686b7e561e2f4b41e3cf589c82c5abafc97 100644
--- a/Source/modules/app_banner/AppBannerPromptResult.h
+++ b/Source/modules/app_banner/AppBannerPromptResult.h
@@ -23,6 +23,8 @@ public:
typedef blink::WebAppBannerPromptResult WebType;
static AppBannerPromptResult* take(ScriptPromiseResolver*, PassOwnPtr<WebAppBannerPromptResult> webInstance);
+ static AppBannerPromptResult* take(PassOwnPtr<WebAppBannerPromptResult> webInstance);
mlamouri (slow - plz ping) 2015/07/24 15:08:25 Do you need to keep the other take method? Same fo
dominickn 2015/07/24 23:53:36 Done.
+
static AppBannerPromptResult* create(const AtomicString& platform, WebAppBannerPromptResult::Outcome outcome)
{
return new AppBannerPromptResult(platform, outcome);

Powered by Google App Engine
This is Rietveld 408576698