Source/modules/app_banner/AppBannerPromptResult.cpp - Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/app_banner/AppBannerPromptResult.cpp

Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace typedef with using as per style guide Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/app_banner/AppBannerPromptResult.h ('K') | « Source/modules/app_banner/AppBannerPromptResult.h ('k') | Source/modules/app_banner/BeforeInstallPromptEvent.h » ('j') | Source/modules/app_banner/BeforeInstallPromptEvent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/app_banner/AppBannerPromptResult.cpp

diff --git a/Source/modules/app_banner/AppBannerPromptResult.cpp b/Source/modules/app_banner/AppBannerPromptResult.cpp

index 128d19ae6f8ead467650325b9cd151a6ca4a1076..38430e1d18846da337f01f84930c5dad02d48c16 100644

--- a/Source/modules/app_banner/AppBannerPromptResult.cpp

+++ b/Source/modules/app_banner/AppBannerPromptResult.cpp

@@ -12,6 +12,12 @@ namespace blink {

// static

AppBannerPromptResult* AppBannerPromptResult::take(ScriptPromiseResolver* resolver, PassOwnPtr<WebAppBannerPromptResult> webInstance)

{

+ return AppBannerPromptResult::take(webInstance);

+// static

+AppBannerPromptResult* AppBannerPromptResult::take(PassOwnPtr<WebAppBannerPromptResult> webInstance)

mlamouri (slow - plz ping) 2015/07/24 15:08:25 ditto, shouldn't you remove the other take method?

dominickn 2015/07/24 23:53:36 Done.

return webInstance ? AppBannerPromptResult::create(webInstance->platform, webInstance->outcome) : nullptr;

}