Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: service/rawdatastore/properties.go

Issue 1247283003: Improve docs (Closed) Base URL: https://github.com/luci/gae.git@reduce_size
Patch Set: fix comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/rawdatastore/errors.go ('k') | service/rawdatastore/serialize.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/rawdatastore/properties.go
diff --git a/service/rawdatastore/properties.go b/service/rawdatastore/properties.go
index d6793df63fd62e9d289710d0ab26c54931b67b98..f1e0341b59ce539577bd59ae536eeec678bb991b 100644
--- a/service/rawdatastore/properties.go
+++ b/service/rawdatastore/properties.go
@@ -258,14 +258,14 @@ func UpconvertUnderlyingType(o interface{}, t reflect.Type) (interface{}, reflec
// Value returns the current value held by this property. It's guaranteed to
// be a valid value type (i.e. `p.SetValue(p.Value(), true)` will never return
// an error).
-func (p Property) Value() interface{} { return p.value }
+func (p *Property) Value() interface{} { return p.value }
// IndexSetting says weather or not the datastore should create indicies for
// this value.
-func (p Property) IndexSetting() IndexSetting { return p.indexSetting }
+func (p *Property) IndexSetting() IndexSetting { return p.indexSetting }
// Type is the PT* type of the data contained in Value().
-func (p Property) Type() PropertyType { return p.propType }
+func (p *Property) Type() PropertyType { return p.propType }
// SetValue sets the Value field of a Property, and ensures that its value
// conforms to the permissible types. That way, you're guaranteed that if you
« no previous file with comments | « service/rawdatastore/errors.go ('k') | service/rawdatastore/serialize.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698