Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4247)

Unified Diff: chrome/test/data/webrtc/manual/peerconnection.js

Issue 12472032: Add screen capture constraints, video tag resize and removed auto video resize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@testingscreen
Patch Set: removed line break Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webrtc/manual/peerconnection.js
diff --git a/chrome/test/data/webrtc/manual/peerconnection.js b/chrome/test/data/webrtc/manual/peerconnection.js
index 5c27fb4303c6d06d0d179263ce93bcfe7ad4b582..1445136f4e5b69dd8e23d557f99adf92ae6142a5 100644
--- a/chrome/test/data/webrtc/manual/peerconnection.js
+++ b/chrome/test/data/webrtc/manual/peerconnection.js
@@ -122,10 +122,16 @@ function forceOpusChanged() {
* the checkboxes for audio and video.
*/
function updateGetUserMediaConstraints() {
- var constraints = {
- audio: $('audio').checked,
- video: $('video').checked
- };
+ if ($('video').checked && $('screencapture').checked)
+ var constraints = {
+ audio: false,
kjellander_chromium 2013/03/25 13:33:58 Is audio not possible to have set to true? If that
jansson 2013/04/05 10:29:42 Done.
+ video: {mandatory: {chromeMediaSource: 'screen'}}
kjellander_chromium 2013/03/25 13:33:58 Is there no way to get both screen capture and a w
jansson 2013/04/05 10:29:42 It's not possible to send both with our test pages
kjellander_chromium 2013/04/08 14:19:51 I think it should be possible according to the spe
+ };
+ else
+ var constraints = {
kjellander_chromium 2013/03/25 13:33:58 Depending on if it's a bug or not to not being abl
jansson 2013/04/05 10:29:42 Done.
+ audio: $('audio').checked,
+ video: $('video').checked
+ };
$('getusermedia-constraints').value =
JSON.stringify(constraints, null, ' ');
}

Powered by Google App Engine
This is Rietveld 408576698