Chromium Code Reviews Chromium Code Reviews
Issue 12472032:
Add screen capture constraints, video tag resize and removed auto video resize (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@testingscreen| Index: chrome/test/data/webrtc/manual/peerconnection.html |
| diff --git a/chrome/test/data/webrtc/manual/peerconnection.html b/chrome/test/data/webrtc/manual/peerconnection.html |
| index ff4c54741170c3f391931f729a4e7600698c344a..dd1a8e4bb6ea9cbc8af0ff42f736b601bfbb2c35 100644 |
| --- a/chrome/test/data/webrtc/manual/peerconnection.html |
| +++ b/chrome/test/data/webrtc/manual/peerconnection.html |
| @@ -12,7 +12,6 @@ |
| </head> |
| <body> |
| -<br/> |
| <div id="wrapper"> |
| <div> |
| GetUserMedia <a href="http://goo.gl/V7cZg">MediaStreamConstraints</a>: |
| @@ -21,25 +20,49 @@ |
| onclick="updateGetUserMediaConstraints();"/> |
| Video<input type="checkbox" id="video" checked |
| onclick="updateGetUserMediaConstraints();"/> |
| + Screen capture<input type="checkbox" id="screencapture" |
| + onclick="updateGetUserMediaConstraints();"/> |
| <button id="re-request" onclick="getUserMediaFromHere();"> |
| Request GetUserMedia</button> |
| Use <a href="constraints.html">constraints.html</a> to create more |
| advanced constraints (then paste them into the box to the left). |
| </div> |
| + |
| <a href="peerconnection-help.html" target="_blank">How does this page work? |
| </a> |
| + |
| <div id="container"> |
| <div id="left-half"> |
| - <h2>Local Preview</h2> |
| - <video width="320" height="240" id="local-view" autoplay="autoplay"> |
| - </video><br/> |
| + <h2>Local Preview</h2> |
|
kjellander_chromium
2013/03/25 13:33:58
Optional: I think it would be great if all the stu
|
| + <video width="320" height="240" id="local-view" autoplay="autoplay"> |
| + </video><br/> |
|
kjellander_chromium
2013/03/25 13:33:58
This line shall actually be indented 4 spaces acco
jansson
2013/04/05 10:29:42
Done.
|
| + |
| + <table> |
|
kjellander_chromium
2013/03/25 13:33:58
Please don't use tables. Divs+CSS should be enough
|
| + <tr> |
| + <td>Size: </td> |
| + <td id="local-view-size"></td> |
| + <td id="local-view-stream-size">(stream size: NA)</td> |
|
kjellander_chromium
2013/03/25 13:33:58
I prefer N/A
jansson
2013/04/05 10:29:42
Done.
|
| + </tr> |
| + </table> |
| + |
| + <table> |
| + <tr> |
| + <td>Resize: </td> |
| + <td><button onclick="updateVideoTagSize_('local-view')"> To stream size |
|
kjellander_chromium
2013/03/25 13:33:58
Wrap properly (applies below too).
|
| + </button></td> |
| + <td><button onclick="updateVideoTagSize_('local-view', '320', '240' |
| + );">320x240</button></td> |
| + <td><button onclick="updateVideoTagSize_('local-view', '640', '480' |
| + );">640x480</button></td> |
| + </tr> |
| + </table> |
| + |
| <h2>Send on data channel</h2> |
| <input type="text" id="data-channel-send" size="10" /> |
| <button onclick="sendDataFromHere();">Send data</button><br> |
| - |
| <h2>Settings</h2> |
|
kjellander_chromium
2013/03/25 13:33:58
I'd like to keep the blank line above this heading
jansson
2013/04/05 10:29:42
Done.
|
| - Server [<a href="" onclick="showServerHelp()">?</a>]: |
| + Server [<a href="" onclick="showServerHelp();">?</a>]: |
| <input type="text" id="server" size="30" |
| value="http://localhost:8888" /> |
| Peer ID: <input type="text" id="peer-id" size="10" /> |
| @@ -78,7 +101,7 @@ |
| <input type="text" id="dtmf-tones-duration" size="10" value="100" /> |
| gap(ms): |
| <input type="text" id="dtmf-tones-gap" size="10" value="50" /> |
| - <button onclick="insertDtmfFromHere();">Send</button><br/> |
| + <button onclick="insertDtmfFromHere();">Send</button><br/> |
| Options: |
| <input type="checkbox" id="force-opus" onclick="forceOpusChanged();"/> |
| Force Opus in Outgoing SDP<br/> |
| @@ -86,17 +109,37 @@ |
| <h2>Messages</h2> |
| <pre id="messages"></pre> |
| </div> |
| + |
| <div id="right-half"> |
| <h2>Remote Video</h2> |
| <video width="320" height="240" id="remote-view" autoplay="autoplay"> |
| </video><br/> |
| + <table> |
|
kjellander_chromium
2013/03/25 13:33:58
Same here, try to work out a layout with divs and
jansson
2013/04/05 10:29:42
Done.
|
| + <tr> |
| + <td>Size: </td> |
| + <td id="remote-view-size"></td> |
| + <td id="remote-view-stream-size">(stream size: NA)</td> |
| + </tr> |
| + </table> |
| + |
| + <table> |
| + <tr> |
| + <td>Resize: </td> |
| + <td><button onclick="updateVideoTagSize_('remote-view')"> To stream size |
| + </button></td> |
| + <td><button onclick="updateVideoTagSize_('remote-view', '320', '240' |
| + );">320x240</button></td> |
| + <td><button onclick="updateVideoTagSize_('remote-view', '640', '480' |
| + );">640x480</button></td> |
| + </tr> |
| + </table> |
| + |
| <h2>Received on data channel</h2> |
| <textarea id="data-channel-receive" rows="7" cols="40" disabled="true"> |
| </textarea> |
| - <h2>Sent DTMF tones</h2> |
| + <h2>Sent DTMF tones</h2> |
| <textarea id="dtmf-tones-sent" rows="7" cols="40" disabled="true"> |
| </textarea> |
| - |
| <h2>Debug</h2> |
|
kjellander_chromium
2013/03/25 13:33:58
I'd like to keep that blank line for improved read
jansson
2013/04/05 10:29:42
Done.
|
| <pre id="debug"></pre> |
| </div> |
