Issue 12472015: Add implementation of WebWidgetClient::initializeLayerTreeView()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12472015: Add implementation of WebWidgetClient::initializeLayerTreeView() (Closed)

Created:
7 years, 9 months ago by jamesr

Modified:
7 years, 9 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add implementation of WebWidgetClient::initializeLayerTreeView() This adds an implementation of WebWidgetClient::initializeLayerTreeView() that takes no parameters. The WLTV::Settings parameter is already ignored and we have (and have to have) API surface to set the root layer so that parameter isn't all that helpful. This has to land and roll before https://bugs.webkit.org/show_bug.cgi?id=111632. After that lands and rolls back into chromium, the 3-param implementation of content::RenderWidget::initializeLayerTreeView() can be removed. R=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186840

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
M	content/renderer/gpu/render_widget_compositor.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	content/renderer/gpu/render_widget_compositor.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/renderer/render_widget.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1 2	1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12472015/7001

7 years, 9 months ago (2013-03-07 23:56:17 UTC) #3

Message was sent while issue was closed.

Change committed as 186840

Expand Messages | Collapse Messages

Issue 12472015: Add implementation of WebWidgetClient::initializeLayerTreeView() (Closed)

Description

Patch Set 1 #

Patch Set 2 : forward declare WLTVClient so definition can be deleted upstream #

Patch Set 3 : null check compositor_, initialization can fail #

Messages