Provide DevToolsHttpHandlerDelegate with an ability to provide additional page info

Provide DevToolsHttpHandlerDelegate with an ability to provide additional page info

For imlementing Android WebView remote debugging, it makes a lot of sense to
provide additional information about debuggable WebViews besides the page title.
This is because WebView-based apps can have a lot of WebViews with no sensible
titles, so picking the one needed becomes a real issue.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187383

[pfeldman, 2013-03-06 17:27:16]

You are about to clash with https://chromiumcodereview.appspot.com/12319114 that
suggests that target info is now manged a bit differently. What is the info you
are trying to pass?

[mnaganov (inactive), 2013-03-07 08:44:41]

On 2013/03/06 17:27:16, pfeldman wrote:
> You are about to clash with https://chromiumcodereview.appspot.com/12319114
that
> suggests that target info is now manged a bit differently. What is the info
you
> are trying to pass?

That's interesting, thanks for pointing me out.

We need to provide some additional information retrieved from the Android views
system, like view visibility status and its screen position. Using only page
titles isn't enough for view identification. For example, this is the list of
view titles I have in the GMail app:

(untitled tab)
about:blank
(untitled tab)
about:blank
(untitled tab)
about:blank

This is what I want to see (an example):

               attached? visible? (x,y)      (w x h)
(untitled tab)    1         1     (801,108)  (0x0)
about:blank       1         1     (801,108)  (800x1170)
(untitled tab)    1         1     (-800,108) (0x0)
about:blank       1         1     (-800,108) (800x1170)
(untitled tab)    1         1     (0,108)    (0x0)
about:blank       1         1     (0,108)    (800x1170)

The delegate can easily provide this taking WebContents as an input.

What is the ETA for the Vlad's patch to land?

[pfeldman, 2013-03-07 09:14:10]

I see. I'd rather let embedder build string titles for your targets. I.e.
instead of providing non-standardized structures, I'd just receive formatted
string.

[mnaganov (inactive), 2013-03-07 10:31:06]

Indeed, this approach is much simpler. PTAL!

[pfeldman, 2013-03-11 09:23:27]

devtools, shell lgtm

[mnaganov (inactive), 2013-03-11 09:27:19]

Need an OWNERS review

Guys, please take a look:

bulach@ - chrome/browser/android
joi@ - content/public/browser

[bulach, 2013-03-11 11:34:33]

lgtm for chrome/browser/android, thanks!

[Jói, 2013-03-11 16:19:52]

LGTM for content/public

[commit-bot: I haz the power, 2013-03-11 16:27:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/12472004/8001

[commit-bot: I haz the power, 2013-03-11 22:00:20]

Change committed as 187383