Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 12472004: Provide DevToolsHttpHandlerDelegate with an ability to provide additional page info (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Hopefully, cover all delegate implementations Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index 665d01f9cfe6dbdcb2b36fe61406819b961eb5c6..8bceba099a721fc41acb71baaacba51d11f4c73b 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -406,6 +406,7 @@ struct DevToolsHttpHandlerImpl::PageInfo {
std::string title;
std::string thumbnail_url;
std::string favicon_url;
+ std::string description;
base::TimeTicks last_selected_time;
};
@@ -870,6 +871,9 @@ DevToolsHttpHandlerImpl::CreatePageInfo(RenderViewHost* rvh,
page_info.favicon_url = entry->GetFavicon().url.spec();
}
}
+
+ page_info.description = delegate_->GetViewDescription(rvh);
+
return page_info;
}
@@ -893,6 +897,7 @@ base::DictionaryValue* DevToolsHttpHandlerImpl::SerializePageInfo(
host);
dictionary->SetString("devtoolsFrontendUrl", devtools_frontend_url);
}
+ dictionary->SetString("description", page_info.description);
return dictionary;
}

Powered by Google App Engine
This is Rietveld 408576698