Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1247063005: Revert of Bilinear optimization for 1D convolution. (Closed)

Created:
5 years, 5 months ago by ericrk
Modified:
5 years, 5 months ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org, vmiuraomon_google.com, Stephen White
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Bilinear optimization for 1D convolution. (patchset #5 id:200001 of https://codereview.chromium.org/1216623003/) Reason for revert: Ok, I am now seeing a couple issues. going to revert and investigate further. Original issue's description: > Bilinear optimization for 1D convolution. > > Splits GrGLConvolutionEffect into GrGLBilerpConvolutionEffect and > GrGLBoundedConvolutionEffect. When doing a non-bounded convolution we now > always use the GrGLBilerpConvolutionEffect which uses bilinear filtering to > perform half as many samples in the texture. > > BUG=skia:3986 > > Committed: https://skia.googlesource.com/skia/+/91abe10af417148939548551e210c001022d3bda > > Committed: https://skia.googlesource.com/skia/+/0f38612b0facf585854aba4556433b858cbf7da8 TBR=bsalomon@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3986 Committed: https://skia.googlesource.com/skia/+/7a787b47437043aacc2d476beab2f531bc02fe9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -305 lines) Patch
M src/gpu/effects/Gr1DKernelEffect.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 6 chunks +114 lines, -291 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ericrk
Created Revert of Bilinear optimization for 1D convolution.
5 years, 5 months ago (2015-07-21 20:48:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247063005/1
5 years, 5 months ago (2015-07-21 20:49:06 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-21 20:49:07 UTC) #3
bsalomon
On 2015/07/21 20:49:07, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 5 months ago (2015-07-21 21:05:42 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:06:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a787b47437043aacc2d476beab2f531bc02fe9d

Powered by Google App Engine
This is Rietveld 408576698