Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: test/promises-aplus/lib/mocha.js

Issue 1246933002: Remove unnecessary coupling between Promise tests and Object.observe (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/mjsunit/es6/promises.js ('K') | « test/promises-aplus/lib/global.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/promises-aplus/lib/mocha.js
diff --git a/test/promises-aplus/lib/mocha.js b/test/promises-aplus/lib/mocha.js
index 24d294ef8f829889fbcdccf1a9893f92635c7aea..f09f11130b2c6a901715d757180de4ca478533be 100644
--- a/test/promises-aplus/lib/mocha.js
+++ b/test/promises-aplus/lib/mocha.js
@@ -42,12 +42,7 @@ var assert = require('assert');
var TIMEOUT = 1000;
function PostMicrotask(fn) {
- var o = {};
- Object.observe(o, function() {
- fn();
- });
- // Change something to enqueue a microtask.
- o.x = 'hello';
+ Promise.resolve().then(fn);
}
var context = {
« test/mjsunit/es6/promises.js ('K') | « test/promises-aplus/lib/global.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698