Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: test/mjsunit/es6/promises.js

Issue 1246933002: Remove unnecessary coupling between Promise tests and Object.observe (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js ('k') | test/promises-aplus/lib/global.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/promises.js
diff --git a/test/mjsunit/es6/promises.js b/test/mjsunit/es6/promises.js
index 63b6d2f94a9a7ec0799a7ef766845675dc8466fb..e3aeb70561a034c5387563ad850428a91db153f5 100644
--- a/test/mjsunit/es6/promises.js
+++ b/test/mjsunit/es6/promises.js
@@ -29,7 +29,6 @@
// Make sure we don't rely on functions patchable by monkeys.
var call = Function.prototype.call.call.bind(Function.prototype.call)
-var observe = Object.observe;
var getOwnPropertyNames = Object.getOwnPropertyNames;
var defineProperty = Object.defineProperty;
var numberPrototype = Number.prototype;
@@ -88,8 +87,7 @@ function assertAsync(b, s) {
function assertAsyncDone(iteration) {
var iteration = iteration || 0
- var dummy = {}
- observe(dummy,
+ Promise.resolve().then(
rossberg 2015/07/21 10:25:37 Some of the tests now become a bit circular (relyi
adamk 2015/07/21 16:18:08 I could switch them all to use %EnqueueMicrotask,
rossberg 2015/07/21 16:28:43 Aw, of course. For some reason I though that can't
function() {
if (asyncAssertsExpected === 0)
assertAsync(true, "all")
@@ -99,7 +97,6 @@ function assertAsyncDone(iteration) {
assertAsyncDone(iteration + 1)
}
)
- dummy.dummy = dummy
}
« no previous file with comments | « test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js ('k') | test/promises-aplus/lib/global.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698