Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 1246863002: Enable MSVC warning C4018 for various directories that seem to pass as-is. (Closed)

Created:
5 years, 5 months ago by Peter Kasting
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
cbentzel+watch_chromium.org, chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable MSVC warning C4018 for various directories that seem to pass as-is. BUG=398202 TEST=none TBR=brettw Committed: https://crrev.com/513df87e8724587dc7be0d27a5f79652275c0767 Cr-Commit-Position: refs/heads/master@{#339602}

Patch Set 1 #

Patch Set 2 : Included 1 extra dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M gpu/gles2_conform_support/gles2_conform_test.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld/cld.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Peter Kasting
5 years, 5 months ago (2015-07-20 23:22:19 UTC) #2
Peter Kasting
(TBRing this since it's mechanical)
5 years, 5 months ago (2015-07-21 02:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246863002/20001
5 years, 5 months ago (2015-07-21 02:05:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 02:46:30 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/513df87e8724587dc7be0d27a5f79652275c0767 Cr-Commit-Position: refs/heads/master@{#339602}
5 years, 5 months ago (2015-07-21 02:47:18 UTC) #7
Matt Giuca
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1242333005/ by mgiuca@chromium.org. ...
5 years, 5 months ago (2015-07-21 03:13:41 UTC) #8
Matt Giuca
5 years, 5 months ago (2015-07-21 03:19:45 UTC) #9
Message was sent while issue was closed.
> Please re-land without the change to gles2_conform_test.gyp..

Actually, I just reverted that one file so no need to reland the other changes.

Powered by Google App Engine
This is Rietveld 408576698