ios/chrome/browser/metrics/ios_stability_metrics_provider.h - Issue 1246843002: Change the meaning of MobileSessionShutdownType's FIRST_LAUNCH_AFTER_UPGRADE bucket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/ios_stability_metrics_provider.h

Issue 1246843002: Change the meaning of MobileSessionShutdownType's FIRST_LAUNCH_AFTER_UPGRADE bucket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep deprecated enum value. Update histograms Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | ios/chrome/browser/metrics/ios_stability_metrics_provider.mm » ('j') | ios/chrome/browser/metrics/ios_stability_metrics_provider.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/ios_stability_metrics_provider.h

diff --git a/ios/chrome/browser/metrics/ios_stability_metrics_provider.h b/ios/chrome/browser/metrics/ios_stability_metrics_provider.h

index 915430766014d11c73d40743c517ff0cc4a1cfaa..bdc6df32a6df4a25ab6fbbb8446b9ff790b263d3 100644

--- a/ios/chrome/browser/metrics/ios_stability_metrics_provider.h

+++ b/ios/chrome/browser/metrics/ios_stability_metrics_provider.h

@@ -21,7 +21,8 @@ enum MobileSessionShutdownType {

SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_NO_MEMORY_WARNING,

SHUTDOWN_IN_FOREGROUND_NO_CRASH_LOG_WITH_MEMORY_WARNING,

SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_WITH_MEMORY_WARNING,

- FIRST_LAUNCH_AFTER_UPGRADE,

+ DEPRECATED_FIRST_LAUNCH_AFTER_UPGRADE,

+ SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,

stuartmorgan 2015/07/21 20:16:24 Seems like we should keep the fact that it's post-

stuartmorgan 2015/07/28 22:27:43 I still think this is true.

MOBILE_SESSION_SHUTDOWN_TYPE_COUNT,

};

« no previous file with comments | « no previous file | ios/chrome/browser/metrics/ios_stability_metrics_provider.mm » ('j') | ios/chrome/browser/metrics/ios_stability_metrics_provider.mm » ('J')