Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: ios/chrome/browser/metrics/ios_stability_metrics_provider.h

Issue 1246843002: Change the meaning of MobileSessionShutdownType's FIRST_LAUNCH_AFTER_UPGRADE bucket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Keep deprecated enum value. Update histograms Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_METRICS_IOS_STABILITY_METRICS_PROVIDER_H_ 5 #ifndef IOS_CHROME_BROWSER_METRICS_IOS_STABILITY_METRICS_PROVIDER_H_
6 #define IOS_CHROME_BROWSER_METRICS_IOS_STABILITY_METRICS_PROVIDER_H_ 6 #define IOS_CHROME_BROWSER_METRICS_IOS_STABILITY_METRICS_PROVIDER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "components/metrics/metrics_provider.h" 10 #include "components/metrics/metrics_provider.h"
11 11
12 namespace metrics { 12 namespace metrics {
13 class MetricsService; 13 class MetricsService;
14 } 14 }
15 15
16 // Exposed for testing purposes only. 16 // Exposed for testing purposes only.
17 // Values of the UMA Stability.MobileSessionShutdownType histogram. 17 // Values of the UMA Stability.MobileSessionShutdownType histogram.
18 enum MobileSessionShutdownType { 18 enum MobileSessionShutdownType {
19 SHUTDOWN_IN_BACKGROUND = 0, 19 SHUTDOWN_IN_BACKGROUND = 0,
20 SHUTDOWN_IN_FOREGROUND_NO_CRASH_LOG_NO_MEMORY_WARNING, 20 SHUTDOWN_IN_FOREGROUND_NO_CRASH_LOG_NO_MEMORY_WARNING,
21 SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_NO_MEMORY_WARNING, 21 SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_NO_MEMORY_WARNING,
22 SHUTDOWN_IN_FOREGROUND_NO_CRASH_LOG_WITH_MEMORY_WARNING, 22 SHUTDOWN_IN_FOREGROUND_NO_CRASH_LOG_WITH_MEMORY_WARNING,
23 SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_WITH_MEMORY_WARNING, 23 SHUTDOWN_IN_FOREGROUND_WITH_CRASH_LOG_WITH_MEMORY_WARNING,
24 FIRST_LAUNCH_AFTER_UPGRADE, 24 DEPRECATED_FIRST_LAUNCH_AFTER_UPGRADE,
25 SHUTDOWN_IN_FOREGROUND_UNKNOWN_LOG_STATE,
stuartmorgan 2015/07/21 20:16:24 Seems like we should keep the fact that it's post-
stuartmorgan 2015/07/28 22:27:43 I still think this is true.
25 MOBILE_SESSION_SHUTDOWN_TYPE_COUNT, 26 MOBILE_SESSION_SHUTDOWN_TYPE_COUNT,
26 }; 27 };
27 28
28 class IOSStabilityMetricsProvider : public metrics::MetricsProvider { 29 class IOSStabilityMetricsProvider : public metrics::MetricsProvider {
29 public: 30 public:
30 explicit IOSStabilityMetricsProvider( 31 explicit IOSStabilityMetricsProvider(
31 metrics::MetricsService* metrics_service); 32 metrics::MetricsService* metrics_service);
32 ~IOSStabilityMetricsProvider() override; 33 ~IOSStabilityMetricsProvider() override;
33 34
34 // metrics::MetricsProvider 35 // metrics::MetricsProvider
(...skipping 19 matching lines...) Expand all
54 55
55 // Whether there was a memory warning shortly before last shutdown. 56 // Whether there was a memory warning shortly before last shutdown.
56 virtual bool ReceivedMemoryWarningBeforeLastShutdown(); 57 virtual bool ReceivedMemoryWarningBeforeLastShutdown();
57 58
58 private: 59 private:
59 metrics::MetricsService* metrics_service_; 60 metrics::MetricsService* metrics_service_;
60 DISALLOW_COPY_AND_ASSIGN(IOSStabilityMetricsProvider); 61 DISALLOW_COPY_AND_ASSIGN(IOSStabilityMetricsProvider);
61 }; 62 };
62 63
63 #endif // IOS_CHROME_BROWSER_METRICS_IOS_STABILITY_METRICS_PROVIDER_H_ 64 #endif // IOS_CHROME_BROWSER_METRICS_IOS_STABILITY_METRICS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698