base/debug/gdi_debug_util_win.cc - Issue 1246833003: Fix and enable MSVC warning C4018 for base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/gdi_debug_util_win.cc

Issue 1246833003: Fix and enable MSVC warning C4018 for base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/gdi_debug_util_win.cc

diff --git a/base/debug/gdi_debug_util_win.cc b/base/debug/gdi_debug_util_win.cc

index 3cd71f1191dd2e2346b9829e38fc65139684c787..2db10d1782290e7877e45291d6ffa80c87bb7c90 100644

--- a/base/debug/gdi_debug_util_win.cc

+++ b/base/debug/gdi_debug_util_win.cc

@@ -75,11 +75,9 @@ void GDIBitmapAllocFailure(BITMAPINFOHEADER* header, HANDLE shared_section) {

base::debug::Alias(&heigth);

base::debug::Alias(&shared_section);

- int num_user_handles = GetGuiResources(GetCurrentProcess(),

- GR_USEROBJECTS);

+ DWORD num_user_handles = GetGuiResources(GetCurrentProcess(), GR_USEROBJECTS);

- int num_gdi_handles = GetGuiResources(GetCurrentProcess(),

- GR_GDIOBJECTS);

+ DWORD num_gdi_handles = GetGuiResources(GetCurrentProcess(), GR_GDIOBJECTS);

if (num_gdi_handles == 0) {

DWORD get_gui_resources_error = GetLastError();

base::debug::Alias(&get_gui_resources_error);