base/base.gypi - Issue 1246833003: Fix and enable MSVC warning C4018 for base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gypi

Issue 1246833003: Fix and enable MSVC warning C4018 for base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base.gypi

diff --git a/base/base.gypi b/base/base.gypi

index 7ffad5417a084a07725fcd1adfb268f89ba5a350..0d0b8e172c6c970dc203cb61386788b2a2280683 100644

--- a/base/base.gypi

+++ b/base/base.gypi

@@ -764,9 +764,6 @@

'include_dirs': [

'..',

- 'msvs_disabled_warnings': [

- 4018,

- ],

'target_conditions': [

['OS == "mac" or OS == "ios"', {

'sources!': [

« no previous file with comments | « no previous file | base/debug/gdi_debug_util_win.cc » ('j') | base/files/file_enumerator_win.cc » ('J')