Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1246773003: Possible fix for Moto E compilation failure (Closed)

Created:
5 years, 5 months ago by robertphillips
Modified:
5 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Possible fix Moto E compilation failure It appears that the Adreno compiler is even more twitchy about gl_FragCoord handling than expected. BUG=skia:4078 Committed: https://skia.googlesource.com/skia/+/18c58c7268e830d5684b97cb010fa1468b16edf9

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : update #

Patch Set 5 : patch for driver bug #

Patch Set 6 : Revert GLProgramsTest.cpp changes #

Patch Set 7 : Fix order (due to codePrependf) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 2 3 4 5 6 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
robertphillips
5 years, 5 months ago (2015-07-21 18:19:15 UTC) #2
bsalomon
lgtm
5 years, 5 months ago (2015-07-21 18:20:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246773003/120001
5 years, 5 months ago (2015-07-21 18:56:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 19:03:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246773003/120001
5 years, 5 months ago (2015-07-21 19:06:04 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:06:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/18c58c7268e830d5684b97cb010fa1468b16edf9

Powered by Google App Engine
This is Rietveld 408576698