Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1246643004: [Extensions UI] Highlight toolbar extensions when the redesign bubble is active (Closed)

Created:
5 years, 5 months ago by Devlin
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting, oshima
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Highlight toolbar extensions when the redesign bubble is active When the redesign bubble is being displayed, highlight extension actions. Clear the highlight when the bubble is dismissed. Also, instead of using the scary developer-mode warning (yellow) highlight, use a softer (blue) highlight. BUG=512905 TBR=oshima@chromium.org (added assets) Committed: https://crrev.com/1f57f746ea2e3f384de0b8ce4ded894e15885b4f Cr-Commit-Position: refs/heads/master@{#340196}

Patch Set 1 #

Total comments: 24

Patch Set 2 : Peter's #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -62 lines) Patch
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_bottom.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_bottom_left.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_bottom_right.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_center.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_left.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_right.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_top.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_top_left.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/toolbar_action_highlight_top_right.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_bottom.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_bottom_left.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_bottom_right.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_center.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_left.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_right.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_top.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_top_left.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/toolbar_action_highlight_top_right.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.h View 4 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 9 chunks +39 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_unittest.cc View 11 chunks +61 lines, -9 lines 0 comments Download
M chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 5 chunks +31 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Devlin
Peter, mind taking a look?
5 years, 5 months ago (2015-07-22 19:10:05 UTC) #2
Peter Kasting
I ask a bunch of dumb questions here because I don't feel like I really ...
5 years, 5 months ago (2015-07-23 00:00:12 UTC) #3
Devlin
Just responding to questions so far; I'll make the code changes when back in the ...
5 years, 5 months ago (2015-07-23 02:43:30 UTC) #4
Peter Kasting
https://codereview.chromium.org/1246643004/diff/1/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/1246643004/diff/1/chrome/app/theme/theme_resources.grd#newcode969 chrome/app/theme/theme_resources.grd:969: <structure type="chrome_scaled_image" name="IDR_TOOLBAR_ACTION_HIGHLIGHT_BOTTOM_LEFT" file="common/toolbar_action_highlight_bottom_left.png" /> On 2015/07/23 at 02:43:30, ...
5 years, 5 months ago (2015-07-23 05:40:53 UTC) #5
Devlin
https://codereview.chromium.org/1246643004/diff/1/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/1246643004/diff/1/chrome/app/theme/theme_resources.grd#newcode969 chrome/app/theme/theme_resources.grd:969: <structure type="chrome_scaled_image" name="IDR_TOOLBAR_ACTION_HIGHLIGHT_BOTTOM_LEFT" file="common/toolbar_action_highlight_bottom_left.png" /> On 2015/07/23 05:40:53, Peter ...
5 years, 5 months ago (2015-07-23 15:30:14 UTC) #6
Peter Kasting
lgtm https://codereview.chromium.org/1246643004/diff/20001/chrome/browser/ui/toolbar/toolbar_actions_bar.h File chrome/browser/ui/toolbar/toolbar_actions_bar.h (right): https://codereview.chromium.org/1246643004/diff/20001/chrome/browser/ui/toolbar/toolbar_actions_bar.h#newcode113 chrome/browser/ui/toolbar/toolbar_actions_bar.h:113: HighlightType GetHighlightType() const; I think this declaration is ...
5 years, 5 months ago (2015-07-23 18:29:07 UTC) #7
Devlin
https://codereview.chromium.org/1246643004/diff/20001/chrome/browser/ui/toolbar/toolbar_actions_bar.h File chrome/browser/ui/toolbar/toolbar_actions_bar.h (right): https://codereview.chromium.org/1246643004/diff/20001/chrome/browser/ui/toolbar/toolbar_actions_bar.h#newcode113 chrome/browser/ui/toolbar/toolbar_actions_bar.h:113: HighlightType GetHighlightType() const; On 2015/07/23 18:29:07, Peter Kasting wrote: ...
5 years, 5 months ago (2015-07-23 20:39:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246643004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1246643004/40001
5 years, 5 months ago (2015-07-23 20:40:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/81541)
5 years, 5 months ago (2015-07-23 20:51:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246643004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1246643004/40001
5 years, 5 months ago (2015-07-23 22:47:11 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-23 22:53:28 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 22:54:31 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f57f746ea2e3f384de0b8ce4ded894e15885b4f
Cr-Commit-Position: refs/heads/master@{#340196}

Powered by Google App Engine
This is Rietveld 408576698