chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc - Issue 1246643004: [Extensions UI] Highlight toolbar extensions when the redesign bubble is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

Issue 1246643004: [Extensions UI] Highlight toolbar extensions when the redesign bubble is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

index 5373da24405cc697e326aba772a2bd5a27a407d5..05d3dbcd551bf8c66da5b9ce84f4c7ffb28548fc 100644

--- a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

+++ b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

@@ -201,7 +201,8 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, HighlightMode) {

extensions::ExtensionIdList extension_ids;

extension_ids.push_back(extension_a()->id());

extension_ids.push_back(extension_b()->id());

- toolbar_model()->HighlightExtensions(extension_ids);

+ toolbar_model()->HighlightExtensions(

+ extension_ids, extensions::ExtensionToolbarModel::HIGHLIGHT_WARNING);

// Only two browser actions should be visible.

EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions());