Change native messaging paths on OSX to /Library/Google/Chrome/NativeMessagingHosts

Change native messaging paths on OSX to /Library/Google/Chrome/NativeMessagingHosts

Previously hosts were located in /Library/Chrome/NativeMessagingHosts. Native
messaging is new and it's disabled by default in M27, so at the moment there
is nothing that depends on the path, i.e. it's still safe to change it.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190494

[Sergey Ulanov, 2013-03-22 22:52:04]

thakis@ suggested changing the path we use for native messaging hosts on OSX
(see https://codereview.chromium.org/12389041). Seems like the right thing to do
for consistency.

[Matt Perry, 2013-03-22 23:27:24]

lgtm

[Mark Mentovai, 2013-03-23 04:10:21]

Through a couple of accidents of history, we dump stuff in /Library/Google with
names that begin with “Google Chrome” instead of putting things in
/Library/Google/Chrome or what we really should have been using,
/Library/Application Support/Google/Chrome.

Examples:

/Library/Google/Google Chrome Brand.plist
/Library/Google/Google Chrome Master Preferences

We can’t change either of these things now, and I’m not sure we should be
putting some Chrome-related things in /Library/Google while we put others a
level deeper in /Library/Google/Chrome. I can be swayed either way on this.

For non-Google Chrome branded unofficial Chromium builds, we don’t have these
accidents to contend with, and you should use /Library/Application
Support/Chromium as your base directory. Yes, this unfortunately does mean an
#ifdef. See src/chrome/browser/mac/master_prefs.mm.

[Nico, 2013-03-23 05:58:09]

On Fri, Mar 22, 2013 at 9:10 PM, <mark@chromium.org> wrote:

> Through a couple of accidents of history, we dump stuff in /Library/Google
> with
> names that begin with “Google Chrome” instead of putting things in
> /Library/Google/Chrome or what we really should have been using,
> /Library/Application Support/Google/Chrome.
>
> Examples:
>
> /Library/Google/Google Chrome Brand.plist
> /Library/Google/Google Chrome Master Preferences
>
> We can’t change either of these things now, and I’m not sure we should be
> putting some Chrome-related things in /Library/Google while we put others a
> level deeper in /Library/Google/Chrome. I can be swayed either way on this.
>

(Since the number of files we put directly in /Library/Google is fairly
small, I suggested going for a folder.)


>
> For non-Google Chrome branded unofficial Chromium builds, we don’t have
> these
> accidents to contend with, and you should use /Library/Application
> Support/Chromium as your base directory. Yes, this unfortunately does mean
> an
> #ifdef. See src/chrome/browser/mac/master_**prefs.mm<http://master_prefs.mm>
> .
>
>
https://codereview.chromium.**org/12465023/<https://codereview.chromium.org/1...
>

[Sergey Ulanov, 2013-03-25 17:19:52]

PTAL. Changed path for unofficial builds. Kept /Library/Google/Chrome for
Official builds on OSX

[Mark Mentovai, 2013-03-25 17:41:30]

LGTM

[commit-bot: I haz the power, 2013-03-25 18:34:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12465023/6001

[Sergey Ulanov, 2013-03-25 22:42:33]

Committed patchset #2 manually as r190494 (presubmit successful).