Source/core/frame/FrameView.cpp - Issue 1246363002: Avoid updating compositor animations in hitTest path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1246363002: Avoid updating compositor animations in hitTest path (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: revert advancing lifecycle to CompositingClean prior to hit testing Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index feffce69b9fc3057ce92d0ef13c11897d32aa012..cbbc6637caac613504dffbad5c4498ec410acc5e 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -2427,12 +2427,6 @@ void FrameView::updateAllLifecyclePhases()

frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(AllPhases);

}

-// TODO(chrishtr): add a scrolling update lifecycle phase.

-void FrameView::updateLifecycleToCompositingCleanPlusScrolling()

- frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(OnlyUpToCompositingCleanPlusScrolling);

esprehn 2015/08/25 07:37:53 This leaves the OnlyUpToCompositingCleanPlusScroll

void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases)

{

// This must be called from the root frame, since it recurses down, not up.

« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »