Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 1246363002: Avoid updating compositor animations in hitTest path (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: revert advancing lifecycle to CompositingClean prior to hit testing Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2409 matching lines...) Expand 10 before | Expand all | Expand 10 after
2420 m_needsUpdateWidgetPositions = false; 2420 m_needsUpdateWidgetPositions = false;
2421 2421
2422 updateWidgetPositions(); 2422 updateWidgetPositions();
2423 } 2423 }
2424 2424
2425 void FrameView::updateAllLifecyclePhases() 2425 void FrameView::updateAllLifecyclePhases()
2426 { 2426 {
2427 frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(AllPhases); 2427 frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(AllPhases);
2428 } 2428 }
2429 2429
2430 // TODO(chrishtr): add a scrolling update lifecycle phase.
2431 void FrameView::updateLifecycleToCompositingCleanPlusScrolling()
2432 {
2433 frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(OnlyUpToComp ositingCleanPlusScrolling);
esprehn 2015/08/25 07:37:53 This leaves the OnlyUpToCompositingCleanPlusScroll
2434 }
2435
2436 void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases) 2430 void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases)
2437 { 2431 {
2438 // This must be called from the root frame, since it recurses down, not up. 2432 // This must be called from the root frame, since it recurses down, not up.
2439 // Otherwise the lifecycles of the frames might be out of sync. 2433 // Otherwise the lifecycles of the frames might be out of sync.
2440 ASSERT(m_frame->isLocalRoot()); 2434 ASSERT(m_frame->isLocalRoot());
2441 2435
2442 // Updating layout can run script, which can tear down the FrameView. 2436 // Updating layout can run script, which can tear down the FrameView.
2443 RefPtrWillBeRawPtr<FrameView> protector(this); 2437 RefPtrWillBeRawPtr<FrameView> protector(this);
2444 2438
2445 updateStyleAndLayoutIfNeededRecursive(); 2439 updateStyleAndLayoutIfNeededRecursive();
(...skipping 1523 matching lines...) Expand 10 before | Expand all | Expand 10 after
3969 3963
3970 if (!graphicsLayer) 3964 if (!graphicsLayer)
3971 return; 3965 return;
3972 3966
3973 DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(localFrame->contentL ayoutObject(), paintInvalidationContainer, viewRect); 3967 DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(localFrame->contentL ayoutObject(), paintInvalidationContainer, viewRect);
3974 3968
3975 graphicsLayerTimingRequests.add(graphicsLayer, Vector<std::pair<int64_t, Web Rect>>()).storedValue->value.append(std::make_pair(m_frame->frameID(), enclosing IntRect(viewRect))); 3969 graphicsLayerTimingRequests.add(graphicsLayer, Vector<std::pair<int64_t, Web Rect>>()).storedValue->value.append(std::make_pair(m_frame->frameID(), enclosing IntRect(viewRect)));
3976 } 3970 }
3977 3971
3978 } // namespace blink 3972 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698