DescriptionDo not do AutoImport on Windows since the import process is already ran earlier as part of ProcessMasterPreferences.
It has to happen earlier (i.e. in PreProfileInit) because the import process interacts with the profile (and we thus want to launch it before profile creation, but after the process singleton has been created).
The reason this needs to happen earlier on Windows is that the import process is completely independent and creates/interacts with the profile itself... on Linux the import is in-process and on Mac we use the out-of-process import with a utility process that talks with the browser process over IPC (but the browser process is still the one doing the interaction with the profile); hence in both cases (Linux/Mac) it makes sense to do the AutoImport after the profile has been initialized, but not on Windows the way the import is currently designed. The best solution is to use the OOP import on Windows as well, but this is a more involved task (http://crbug.com/22142) and should be done in a follow-up CL (the OOP import is actually not very platform-specific as it stands, but it will need to be tweaked to support IE, etc.).
This still has the issue that it's done before the process singleton is grabbed (and thus could potentially be launched more than once...).
BUG=219419
TEST=Import process is launched only once whether there is a master_preferences file or not.
Patch Set 1 #
Total comments: 14
Patch Set 2 : adressed joao's comments #Patch Set 3 : Move import task from ProcessMasterPreferences() to PreProfileInit(). #
Total comments: 11
Patch Set 4 : fix posix compile #
Messages
Total messages: 16 (0 generated)
|