Issue 12463019: Merge 144789

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12463019: Merge 144789 (Closed)

Created:
7 years, 9 months ago by scherkus (not reviewing)

Modified:
7 years, 9 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

More Reviews

Description

Merge 144789 > REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path. > https://bugs.webkit.org/show_bug.cgi?id=111109 > > Reviewed by Eric Carlson. > > Source/WebCore: > > Covered by following tests: > media/track/track-cue-rendering-horizontal.html > media/track/track-cue-rendering-vertical.html > > * rendering/RenderTheme.cpp: > (WebCore::RenderTheme::paint): > * rendering/RenderTheme.h: > (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): > > LayoutTests: > > * platform/chromium/TestExpectations: TBR=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144967

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -0 lines)			Patch
M	LayoutTests/platform/chromium/TestExpectations	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/WebCore/rendering/RenderTheme.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/rendering/RenderTheme.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

7 years, 9 months ago (2013-03-06 20:56:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r144967.

Expand Messages | Collapse Messages