Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/common/extensions/permissions/api_permission.cc

Issue 12463015: Enable <adview> tag for packaged apps. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebasing Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/api_permission.cc
diff --git a/chrome/common/extensions/permissions/api_permission.cc b/chrome/common/extensions/permissions/api_permission.cc
index 78a861ee077ef2941c0cf7a01c27c0184721e881..929b54cd3a7269338221b3a93c2f4610954c1703 100644
--- a/chrome/common/extensions/permissions/api_permission.cc
+++ b/chrome/common/extensions/permissions/api_permission.cc
@@ -195,6 +195,7 @@ void APIPermissionInfo::RegisterAllPermissions(
// Register extension permissions.
{ APIPermission::kActiveTab, "activeTab" },
+ { APIPermission::kAdView, "adview", kFlagCannotBeOptional },
asargent_no_longer_on_chrome 2013/03/09 00:51:05 Any reason not to let this be an optional permissi
rpaquay 2013/03/12 19:56:48 <webview> is non optional too. Reading the link ab
asargent_no_longer_on_chrome 2013/03/12 20:54:27 Note that the *developer* gets to choose if the pe
rpaquay 2013/03/12 23:05:36 Oh I see, I missed that part, sorry. I think you a
{ APIPermission::kAlarms, "alarms" },
{ APIPermission::kBookmark, "bookmarks", kFlagNone,
IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS,

Powered by Google App Engine
This is Rietveld 408576698