Enable <adview> tag for packaged apps.

chrome/common/extensions/permissions/api_permission.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permissions/api_permission.h"
 
 #include "chrome/common/extensions/permissions/bluetooth_device_permission.h"
 #include "chrome/common/extensions/permissions/media_galleries_permission.h"
 #include "chrome/common/extensions/permissions/permissions_info.h"
 #include "chrome/common/extensions/permissions/socket_permission.h"
@@ skipping 177 matching lines @@
     { APIPermission::kNotification, "notifications" },
     { APIPermission::kScreensaver, "screensaver" },
     { APIPermission::kUnlimitedStorage, "unlimitedStorage",
       kFlagCannotBeOptional },
 
     // Register hosted and packaged app permissions.
     { APIPermission::kAppNotifications, "appNotifications" },
 
     // Register extension permissions.
     { APIPermission::kActiveTab, "activeTab" },
+    { APIPermission::kAdView, "adview", kFlagCannotBeOptional },

[asargent_no_longer_on_chrome, 2013/03/09 00:51:05]

Any reason not to let this be an optional permission? 

In case you aren't familiar with optional permissions, they are described here:

https://developer.chrome.com/extensions/permissions.html

[rpaquay, 2013/03/12 19:56:48]

<webview> is non optional too. Reading the link above, I would probably argue
that ads should be non-optional too: It makes the developer's life slightly more
difficult, and it is not clear to me it would be a good user experience to
display a "Confirm permission dialog" just before an ad is displayed. It sounds
a bit intrusive.

[asargent_no_longer_on_chrome, 2013/03/12 20:54:27]

Note that the *developer* gets to choose if the permission is required or
optional. Listing a permission under the 'permissions' key of their manifest
makes it required, and listing it in the 'optional_permissions' key makes it
optional. Also, the permission request is only a one-time thing if the user
agrees to it, then the system remembers that (I think it's stored in
ExtensionPrefs). 

Anyhow, I don't think this is a big deal either way, and  I wouldn't expect many
developers to choose to make ads optional. 

[rpaquay, 2013/03/12 23:05:36]

Oh I see, I missed that part, sorry. I think you are right then, we should leave
the possibility of making the permission optional.

     { APIPermission::kAlarms, "alarms" },
     { APIPermission::kBookmark, "bookmarks", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS,
       PermissionMessage::kBookmarks },
     { APIPermission::kBrowsingData, "browsingData" },
     { APIPermission::kContentSettings, "contentSettings", kFlagNone,
       IDS_EXTENSION_PROMPT_WARNING_CONTENT_SETTINGS,
       PermissionMessage::kContentSettings },
     { APIPermission::kContextMenus, "contextMenus" },
     { APIPermission::kCookie, "cookies" },
@@ skipping 161 matching lines @@
         pr.flags,
         pr.constructor);
   }
 
   // Register aliases.
   info->RegisterAlias("unlimitedStorage", kOldUnlimitedStoragePermission);
   info->RegisterAlias("tabs", kWindowsPermission);
 }
 
 }  // namespace extensions