Enable <adview> tag for packaged apps.

chrome/renderer/extensions/dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/dispatcher.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_piece.h"
@@ skipping 826 matching lines @@
   source_map_.RegisterSource("binding", IDR_BINDING_JS);
 
   // Platform app sources that are not API-specific..
   source_map_.RegisterSource("tagWatcher", IDR_TAG_WATCHER_JS);
   // Note: webView not webview so that this doesn't interfere with the
   // chrome.webview API bindings.
   source_map_.RegisterSource("webView", IDR_WEB_VIEW_JS);
   source_map_.RegisterSource("webViewExperimental",
                              IDR_WEB_VIEW_EXPERIMENTAL_JS);
   source_map_.RegisterSource("denyWebView", IDR_WEB_VIEW_DENY_JS);
+  source_map_.RegisterSource("adView", IDR_AD_VIEW_JS);
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableAdviewSrcAttribute)) {
+    source_map_.RegisterSource("adViewCustom", IDR_AD_VIEW_CUSTOM_JS);
+  }
+  source_map_.RegisterSource("denyAdView", IDR_AD_VIEW_DENY_JS);
   source_map_.RegisterSource("platformApp", IDR_PLATFORM_APP_JS);
   source_map_.RegisterSource("injectAppTitlebar", IDR_INJECT_APP_TITLEBAR_JS);
 }
 
 void Dispatcher::PopulateLazyBindingsMap() {
   lazy_bindings_map_["app"] = InstallAppBindings;
   lazy_bindings_map_["webstore"] = InstallWebstoreBindings;
 }
 
 void Dispatcher::InstallBindings(ModuleSystem* module_system,
@@ skipping 124 matching lines @@
     // The API will be automatically set up when first used.
     if (extension->HasAPIPermission(APIPermission::kWebView)) {
       module_system->Require("webView");
       if (Feature::GetCurrentChannel() <= chrome::VersionInfo::CHANNEL_DEV)
         module_system->Require("webViewExperimental");
     } else {
       module_system->Require("denyWebView");
     }
   }
 
+  if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) {

[Fady Samuel, 2013/03/18 18:48:05]

https://codereview.chromium.org/12496015/patch/3001/4001

Make sure you enable adView only in Platform apps and not extensions.

+    if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableAdview)) {
+      if (extension->HasAPIPermission(APIPermission::kAdView)) {
+        if (CommandLine::ForCurrentProcess()->HasSwitch(
+                switches::kEnableAdviewSrcAttribute)) {
+          module_system->Require("adViewCustom");
+        }
+        module_system->Require("adView");
+      } else {
+        module_system->Require("denyAdView");
+      }
+    }
+  }
+
   context->set_module_system(module_system.Pass());
 
   context->DispatchOnLoadEvent(
       ChromeRenderProcessObserver::is_incognito_process(),
       manifest_version);
 
   VLOG(1) << "Num tracked contexts: " << v8_context_set_.size();
 }
 
 std::string Dispatcher::GetExtensionID(const WebFrame* frame, int world_id) {
@@ skipping 315 matching lines @@
     std::string error_msg = base::StringPrintf(kMessage, function_name.c_str());
     v8::ThrowException(
         v8::Exception::Error(v8::String::New(error_msg.c_str())));
     return false;
   }
 
   return true;
 }
 
 }  // namespace extensions