Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4207)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 12496015: Make sure only platform app support <webview> tag (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 887a26df22a8931c14243bb13e37ebe5eeeae364..3366165da50be5db0d56309f27d19908e5537bc1 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -981,7 +981,11 @@ void Dispatcher::DidCreateScriptContext(
if (IsWithinPlatformApp(frame))
module_system->Require("platformApp");
- if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) {
+ // Only platform app need to support <webview> tag, "webView" and
Charlie Reis 2013/03/18 15:16:05 Please fix typos: Only platform apps support the <
+ // "denyWebView" modules will effect the performace of the DOM modification
Charlie Reis 2013/03/18 15:16:05 nit: will effect -> affect nit: performance of DOM
+ // (http://crbug.com/196453).
+ if (context_type == Feature::BLESSED_EXTENSION_CONTEXT &&
+ IsWithinPlatformApp(frame)) {
PhistucK 2013/03/18 17:50:41 Just driving by - Maybe cache the result of IsWith
// Note: setting up the WebView class here, not the chrome.webview API.
// The API will be automatically set up when first used.
if (extension->HasAPIPermission(APIPermission::kWebView)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698