Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 12463007: Disable partial swaps for webview guest renderer until we can figure out how to do that properly. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Version 2, plumb through the renderer. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/view_messages.h » ('j') | content/public/common/renderer_preferences.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index 5e64ff8d944965be51372fd60bd8612e18d56700..ee575e20d2b578ea7e3b972afa3ba615b5899694 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -90,6 +90,8 @@ BrowserPluginGuest::BrowserPluginGuest(
// update the BrowserPlugin's corresponding 'name' attribute.
// TODO(fsamuel): Remove this once http://crbug.com/169110 is addressed.
renderer_prefs->report_frame_name_changes = true;
+ // Webview compositing does not currently work with partial swaps.
Fady Samuel 2013/03/06 18:59:38 Please avoid using the term webview in BrowserPlug
+ renderer_prefs->allow_partial_swap = false;
// Navigation is disabled in Chrome Apps. We want to make sure guest-initiated
// navigations still continue to function inside the app.
renderer_prefs->browser_handles_all_top_level_requests = false;
« no previous file with comments | « no previous file | content/common/view_messages.h » ('j') | content/public/common/renderer_preferences.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698