Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 12463007: Disable partial swaps for webview guest renderer until we can figure out how to do that properly. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Version 2, plumb through the renderer. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_plugin/browser_plugin_guest.h" 5 #include "content/browser/browser_plugin/browser_plugin_guest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 // For GTK and Aura this is necessary to get proper renderer configuration 83 // For GTK and Aura this is necessary to get proper renderer configuration
84 // values for caret blinking interval, colors related to selection and 84 // values for caret blinking interval, colors related to selection and
85 // focus. 85 // focus.
86 *renderer_prefs = *embedder_web_contents->GetMutableRendererPrefs(); 86 *renderer_prefs = *embedder_web_contents->GetMutableRendererPrefs();
87 87
88 renderer_prefs->throttle_input_events = false; 88 renderer_prefs->throttle_input_events = false;
89 // We would like the guest to report changes to frame names so that we can 89 // We would like the guest to report changes to frame names so that we can
90 // update the BrowserPlugin's corresponding 'name' attribute. 90 // update the BrowserPlugin's corresponding 'name' attribute.
91 // TODO(fsamuel): Remove this once http://crbug.com/169110 is addressed. 91 // TODO(fsamuel): Remove this once http://crbug.com/169110 is addressed.
92 renderer_prefs->report_frame_name_changes = true; 92 renderer_prefs->report_frame_name_changes = true;
93 // Webview compositing does not currently work with partial swaps.
Fady Samuel 2013/03/06 18:59:38 Please avoid using the term webview in BrowserPlug
94 renderer_prefs->allow_partial_swap = false;
93 // Navigation is disabled in Chrome Apps. We want to make sure guest-initiated 95 // Navigation is disabled in Chrome Apps. We want to make sure guest-initiated
94 // navigations still continue to function inside the app. 96 // navigations still continue to function inside the app.
95 renderer_prefs->browser_handles_all_top_level_requests = false; 97 renderer_prefs->browser_handles_all_top_level_requests = false;
96 } 98 }
97 99
98 void BrowserPluginGuest::Destroy() { 100 void BrowserPluginGuest::Destroy() {
99 if (destroy_called_) 101 if (destroy_called_)
100 return; 102 return;
101 destroy_called_ = true; 103 destroy_called_ = true;
102 embedder_web_contents_ = NULL; 104 embedder_web_contents_ = NULL;
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
874 relay_params.bitmap_rect = params.bitmap_rect; 876 relay_params.bitmap_rect = params.bitmap_rect;
875 relay_params.scroll_delta = params.scroll_delta; 877 relay_params.scroll_delta = params.scroll_delta;
876 relay_params.scroll_rect = params.scroll_rect; 878 relay_params.scroll_rect = params.scroll_rect;
877 relay_params.copy_rects = params.copy_rects; 879 relay_params.copy_rects = params.copy_rects;
878 880
879 SendMessageToEmbedder( 881 SendMessageToEmbedder(
880 new BrowserPluginMsg_UpdateRect(instance_id(), relay_params)); 882 new BrowserPluginMsg_UpdateRect(instance_id(), relay_params));
881 } 883 }
882 884
883 } // namespace content 885 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/common/view_messages.h » ('j') | content/public/common/renderer_preferences.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698