Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1246253002: Convert i18n_process.css to use /deep/ instead of ::shadow and add tests. (Closed)

Created:
5 years, 5 months ago by Dan Beam
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang, esprehn
CC:
chromium-reviews, kevers, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert i18n_process.css to use * /deep/ instead of ::shadow and add tests. R=esprehn@chromium.org,thestig@chromium.org BUG=511486 Committed: https://crrev.com/194f2a8c152493bdeb27e70f336b14469ced232d Cr-Commit-Position: refs/heads/master@{#339814}

Patch Set 1 : +GN #

Total comments: 8

Patch Set 2 : move .gn file #

Patch Set 3 : esprehn@ review #

Total comments: 2

Patch Set 4 : GN fix #

Patch Set 5 : thestig@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -35 lines) Patch
M chrome/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 2 chunks +17 lines, -0 lines 0 comments Download
A chrome/test/data/BUILD.gn View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/test/data/webui/i18n_process_css_test.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 2 3 4 11 chunks +39 lines, -26 lines 0 comments Download
A chrome/test/data/webui_test_resources.grd View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +5 lines, -1 line 0 comments Download
M ui/webui/resources/css/i18n_process.css View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/webui/resources/js/webui_resource_test.js View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Dan Beam
yeah, it really does require touching that many files in some cases to add a ...
5 years, 5 months ago (2015-07-21 23:37:38 UTC) #3
esprehn
This seems fine, but I don't know anything about grit and those template files so ...
5 years, 5 months ago (2015-07-21 23:42:02 UTC) #4
Dan Beam
+thestig@ for "grit and those template files" https://codereview.chromium.org/1246253002/diff/40001/chrome/test/data/webui/i18n_process_css_test.html File chrome/test/data/webui/i18n_process_css_test.html (right): https://codereview.chromium.org/1246253002/diff/40001/chrome/test/data/webui/i18n_process_css_test.html#newcode2 chrome/test/data/webui/i18n_process_css_test.html:2: <html> On ...
5 years, 5 months ago (2015-07-22 00:15:40 UTC) #6
Lei Zhang
https://codereview.chromium.org/1246253002/diff/80001/chrome/test/data/webui/webui_resource_browsertest.cc File chrome/test/data/webui/webui_resource_browsertest.cc (right): https://codereview.chromium.org/1246253002/diff/80001/chrome/test/data/webui/webui_resource_browsertest.cc#newcode16 chrome/test/data/webui/webui_resource_browsertest.cc:16: #include "grit/webui_test_resources.h" Can this be chrome/test/data/grit/webui_test_resources.h? Adjust build rules ...
5 years, 5 months ago (2015-07-22 00:20:26 UTC) #7
Dan Beam
https://codereview.chromium.org/1246253002/diff/80001/chrome/test/data/webui/webui_resource_browsertest.cc File chrome/test/data/webui/webui_resource_browsertest.cc (right): https://codereview.chromium.org/1246253002/diff/80001/chrome/test/data/webui/webui_resource_browsertest.cc#newcode16 chrome/test/data/webui/webui_resource_browsertest.cc:16: #include "grit/webui_test_resources.h" On 2015/07/22 00:20:26, Lei Zhang wrote: > ...
5 years, 5 months ago (2015-07-22 00:26:41 UTC) #8
Lei Zhang
On 2015/07/22 00:26:41, Dan Beam wrote: > grit/ is what almost everybody does: > https://code.google.com/p/chromium/codesearch#search/&q=type%20rc_header%20file:.grd$&sq=package:chromium&type=cs&p=3 ...
5 years, 5 months ago (2015-07-22 00:35:02 UTC) #9
Dan Beam
On 2015/07/22 00:35:02, Lei Zhang wrote: > On 2015/07/22 00:26:41, Dan Beam wrote: > > ...
5 years, 5 months ago (2015-07-22 00:42:53 UTC) #10
Lei Zhang
On 2015/07/22 00:42:53, Dan Beam wrote: > On 2015/07/22 00:35:02, Lei Zhang wrote: > > ...
5 years, 5 months ago (2015-07-22 00:45:53 UTC) #11
Lei Zhang
lgtm
5 years, 5 months ago (2015-07-22 00:46:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246253002/120001
5 years, 5 months ago (2015-07-22 00:51:13 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:120001)
5 years, 5 months ago (2015-07-22 01:52:59 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 01:54:03 UTC) #16
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/194f2a8c152493bdeb27e70f336b14469ced232d
Cr-Commit-Position: refs/heads/master@{#339814}

Powered by Google App Engine
This is Rietveld 408576698