Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1076093002: Minimize flicker by adding a   to nodes that will have (Closed)

Created:
5 years, 8 months ago by Dan Beam
Modified:
5 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, oshima+watch_chromium.org, arv (Not doing code reviews), Pat Meenan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minimize flicker by adding a   to nodes that will have their content replaced by i18n_process.js. R=estade@chromium.org BUG=466914 Committed: https://crrev.com/9045adae17d792e3d0c475f90e906de2b29df1e2 Cr-Commit-Position: refs/heads/master@{#324767}

Patch Set 1 #

Total comments: 5

Patch Set 2 : estade@ review #

Total comments: 5

Patch Set 3 : -:empty #

Patch Set 4 : ::after -> ::before #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M chrome/browser/resources/bookmark_manager/main.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/css/chrome_shared.css View 1 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/css/i18n_process.css View 1 2 3 1 chunk +9 lines, -0 lines 1 comment Download
M ui/webui/resources/js/i18n_template_no_process.js View 1 2 chunks +6 lines, -3 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dan Beam
https://codereview.chromium.org/1076093002/diff/1/ui/webui/resources/css/widgets.css File ui/webui/resources/css/widgets.css (right): https://codereview.chromium.org/1076093002/diff/1/ui/webui/resources/css/widgets.css#newcode121 ui/webui/resources/css/widgets.css:121: [i18n-values*=".innerHTML:"]:empty { so, what's the chance that even after ...
5 years, 8 months ago (2015-04-10 02:32:59 UTC) #1
Evan Stade
https://codereview.chromium.org/1076093002/diff/1/ui/webui/resources/css/widgets.css File ui/webui/resources/css/widgets.css (right): https://codereview.chromium.org/1076093002/diff/1/ui/webui/resources/css/widgets.css#newcode121 ui/webui/resources/css/widgets.css:121: [i18n-values*=".innerHTML:"]:empty { On 2015/04/10 02:32:59, Dan Beam wrote: > ...
5 years, 8 months ago (2015-04-10 14:14:41 UTC) #2
Dan Beam
https://codereview.chromium.org/1076093002/diff/1/ui/webui/resources/css/widgets.css File ui/webui/resources/css/widgets.css (right): https://codereview.chromium.org/1076093002/diff/1/ui/webui/resources/css/widgets.css#newcode121 ui/webui/resources/css/widgets.css:121: [i18n-values*=".innerHTML:"]:empty { On 2015/04/10 14:14:41, Evan Stade wrote: > ...
5 years, 8 months ago (2015-04-10 23:42:52 UTC) #5
Evan Stade
lgtm https://codereview.chromium.org/1076093002/diff/60001/ui/webui/resources/css/i18n_process.css File ui/webui/resources/css/i18n_process.css (right): https://codereview.chromium.org/1076093002/diff/60001/ui/webui/resources/css/i18n_process.css#newcode5 ui/webui/resources/css/i18n_process.css:5: html:not(.i18n-processed) [i18n-content]:empty::after, do you still need the :empty?
5 years, 8 months ago (2015-04-10 23:56:59 UTC) #6
Dan Beam
https://codereview.chromium.org/1076093002/diff/60001/ui/webui/resources/css/i18n_process.css File ui/webui/resources/css/i18n_process.css (right): https://codereview.chromium.org/1076093002/diff/60001/ui/webui/resources/css/i18n_process.css#newcode5 ui/webui/resources/css/i18n_process.css:5: html:not(.i18n-processed) [i18n-content]:empty::after, On 2015/04/10 23:56:59, Evan Stade wrote: > ...
5 years, 8 months ago (2015-04-11 00:48:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076093002/100001
5 years, 8 months ago (2015-04-11 00:51:36 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 8 months ago (2015-04-11 03:44:28 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 03:45:20 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9045adae17d792e3d0c475f90e906de2b29df1e2
Cr-Commit-Position: refs/heads/master@{#324767}

Powered by Google App Engine
This is Rietveld 408576698