Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1536)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/libxml/BUILD.gn

Issue 1246103007: Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/leveldatabase/BUILD.gn ('K') | « third_party/libexif/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/BUILD.gn
diff --git a/third_party/libxml/BUILD.gn b/third_party/libxml/BUILD.gn
index 1f10dee5889d545ecb672337e083253c172e51bb..58a5f1c1040d3ae8ad8909da52d7d56c84c4c191 100644
--- a/third_party/libxml/BUILD.gn
+++ b/third_party/libxml/BUILD.gn
@@ -155,7 +155,10 @@ static_library("libxml") {
]
if (is_win) {
- cflags_c = [ "/wd4101" ] # Unreferenced local variable.
+ cflags_c = [
+ "/wd4018", # Signed/unsigned mismatch in comparison.
+ "/wd4101", # Unreferenced local variable.
+ ]
} else if (is_mac || is_ios || is_android) {
# http://www.xmlsoft.org/threads.html says that this is required when using
# libxml from several threads, which can possibly happen in chrome. On
« third_party/leveldatabase/BUILD.gn ('K') | « third_party/libexif/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698