third_party/leveldatabase/BUILD.gn - Issue 1246103007: Enable C4018 globally for the GN build, and disable per-target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/leveldatabase/BUILD.gn

Issue 1246103007: Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/leveldatabase/BUILD.gn

diff --git a/third_party/leveldatabase/BUILD.gn b/third_party/leveldatabase/BUILD.gn

index ca51867d856397a4e054fc5a3d8c4a2e0eeea339..9b73855657de2f723010c0f1b92a3d2370019a0a 100644

--- a/third_party/leveldatabase/BUILD.gn

+++ b/third_party/leveldatabase/BUILD.gn

@@ -117,6 +117,10 @@ static_library("leveldatabase") {

}

if (!is_android) {

+ if (is_win) {

+ cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.

brettw 2015/07/22 04:30:25 You'll want to put this above in the "leveldatabas

Peter Kasting 2015/07/22 05:58:08 That would explain the bot failure...

+ }

test("env_chromium_unittests") {

sources = [

"env_chromium_unittest.cc",

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/libexif/BUILD.gn » ('j') | no next file with comments »