Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 124603003: Change the pageaction_by_content example to use declarativeContent. (Closed)

Created:
6 years, 11 months ago by Jeffrey Yasskin
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Change the pageaction_by_content example to use declarativeContent. The "Mappy" sample still provides an example of a content script searching for text. The new icon comes from http://en.wikipedia.org/wiki/File:Video_icon2.png, which is public domain. TEST=Install the extension, and visit http://www.html5rocks.com/en/tutorials/video/basics/. The page action icon should show up. BUG=330359 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243475

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
Jeffrey Yasskin
6 years, 11 months ago (2014-01-06 23:59:35 UTC) #1
Yoyo Zhou
LGTM
6 years, 11 months ago (2014-01-07 02:27:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/124603003/1
6 years, 11 months ago (2014-01-07 18:38:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242628
6 years, 11 months ago (2014-01-07 21:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/124603003/1
6 years, 11 months ago (2014-01-07 22:55:23 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242933
6 years, 11 months ago (2014-01-08 02:02:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/124603003/1
6 years, 11 months ago (2014-01-08 02:48:21 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 02:49:43 UTC) #8
Message was sent while issue was closed. 
Change committed as 243475

Powered by Google App Engine
This is Rietveld 408576698