Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3825)

Unified Diff: chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_content/manifest.json

Issue 124603003: Change the pageaction_by_content example to use declarativeContent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_content/manifest.json
diff --git a/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_content/manifest.json b/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_content/manifest.json
index 2b09d279021aa29214f0d4cb9fa21a608f72158d..79134a72efaffe0f62f5c79194c063082e71772e 100644
--- a/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_content/manifest.json
+++ b/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_content/manifest.json
@@ -1,29 +1,20 @@
{
"name" : "Page action by content",
"version" : "1.1",
- "description" : "Shows a page action for HTML pages containing the word 'sandwich'",
+ "description" : "Shows a page action for HTML pages containing a video",
"background" : {
- "scripts": ["background.js"]
+ "scripts": ["background.js"],
+ "persistent": false
},
"page_action" :
{
- "default_icon" : "sandwich-19.png",
- "default_title" : "There's a 'sandwich' in this page!"
+ "default_icon" : "video-19.png",
+ "default_title" : "There's a <video> in this page!"
},
- "content_scripts" : [
- {
- "matches" : [
- "http://*/*",
- "https://*/*"
- ],
- "js" : ["contentscript.js"],
- "run_at" : "document_idle",
- "all_frames" : false
- }
- ],
+ "permissions": [ "declarativeContent" ],
"icons" : {
- "48" : "sandwich-48.png",
- "128" : "sandwich-128.png"
+ "48" : "video-48.png",
+ "128" : "video-128.png"
},
"manifest_version": 2
-}
+}

Powered by Google App Engine
This is Rietveld 408576698