Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1246013003: Revert "Preliminary support for Windows manifests in the GN build." (Closed)

Created:
5 years, 5 months ago by Denis Kuznetsov (DE-MUC)
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Preliminary support for Windows manifests in the GN build." This reverts commit c34cad367a0557d8b029fb81d04cc37b5979fee0. This reverts https://codereview.chromium.org/1240893004/ BUG=510612 TBR=brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -230 lines) Patch
D build/config/win/manifest.gni View 1 chunk +0 lines, -182 lines 0 comments Download
D build/win/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D build/win/as_invoker.manifest View 1 chunk +0 lines, -9 lines 0 comments Download
D build/win/common_controls.manifest View 1 chunk +0 lines, -8 lines 0 comments Download
A + cloud_print/service/win/common-controls.manifest View 0 chunks +-1 lines, --1 lines 0 comments Download
M cloud_print/service/win/service.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 3 chunks +1 line, -4 lines 0 comments Download
A + remoting/host/win/common-controls.manifest View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 chunk +1 line, -1 line 0 comments Download
M testing/test.gni View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246013003/1
5 years, 5 months ago (2015-07-21 17:05:15 UTC) #2
commit-bot: I haz the power
Failed to apply patch for cloud_print/service/win/common-controls.manifest: While running git apply --index -3 -p1; error: build/win/common_controls.manifest: ...
5 years, 5 months ago (2015-07-21 17:06:56 UTC) #5
Denis Kuznetsov (DE-MUC)
5 years, 5 months ago (2015-07-21 17:07:31 UTC) #6
On 2015/07/21 17:05:15, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1246013003/1

Also reverted by https://codereview.chromium.org/1249723002, unchecking CQ bit.

Powered by Google App Engine
This is Rietveld 408576698