document.querySelector[All]() should check selector context

document.querySelector[All]() should check selector context

Blink failed to check whether the left-most matched selector ends up
in Document TreeScope.
The check was only enabled for querySelector*() is called on
a regular element, not on document.

This issue can be exposed by passing "::shadow" or "/deep/"
which pierces shadow boundary and the selector can
incorrectly match inside shadow.

BUG=511486
TEST=fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201461

[kochi, 2015-07-21 09:38:47]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 09:38:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245933002/1

[commit-bot: I haz the power, 2015-07-21 11:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 11:09:06]

Dry run: Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/71050)

[kochi, 2015-08-28 10:12:06]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 10:12:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1245933002/80001

[kochi, 2015-08-28 10:15:58]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 10:16:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245933002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1245933002/100001

[commit-bot: I haz the power, 2015-08-28 11:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 11:38:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kochi, 2015-08-28 23:36:28]

kochi@chromium.org changed reviewers:
+ esprehn@chromium.org

[kochi, 2015-08-28 23:36:44]

Elliott, could you review this?

[esprehn, 2015-08-29 23:55:30]

lgtm, but is scopeContainsLastMatchedElement really needed at all?

https://codereview.chromium.org/1245933002/diff/100001/Source/core/dom/Select...
File Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/1245933002/diff/100001/Source/core/dom/Select...
Source/core/dom/SelectorQuery.cpp:126:
selectorCheckingContext.scopeContainsLastMatchedElement = true;
Why do we need scopeContainsLastMatchedElement at all?

[kochi, 2015-08-31 03:31:48]

Thanks for the review.

On 2015/08/29 23:55:30, esprehn wrote:
> lgtm, but is scopeContainsLastMatchedElement really needed at all?
> 
>
https://codereview.chromium.org/1245933002/diff/100001/Source/core/dom/Select...
> File Source/core/dom/SelectorQuery.cpp (right):
> 
>
https://codereview.chromium.org/1245933002/diff/100001/Source/core/dom/Select...
> Source/core/dom/SelectorQuery.cpp:126:
> selectorCheckingContext.scopeContainsLastMatchedElement = true;
> Why do we need scopeContainsLastMatchedElement at all?

Are you proposing to remove the flag completely, or asking the reason
to this particular instance (probably, the former)?
Last time I tried sometime ago, it was not possible, but now it may be possible.
I'll try it later.

[kochi, 2015-08-31 03:31:53]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2015-08-31 03:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245933002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1245933002/100001

[commit-bot: I haz the power, 2015-08-31 04:42:25]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201461

[kochi, 2015-09-01 02:20:08]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1329523002/ by kochi@chromium.org.

The reason for reverting is: This seems to have caused a significant perf
regression.  Reverting.

BUG=526742.