Source/core/dom/SelectorQuery.cpp - Issue 1245933002: document.querySelector[All]() should check selector context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/SelectorQuery.cpp

Issue 1245933002: document.querySelector[All]() should check selector context (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/SelectorQuery.cpp

diff --git a/Source/core/dom/SelectorQuery.cpp b/Source/core/dom/SelectorQuery.cpp

index 572180d2523e2f0ed1b15c571d590ccf27ae2a36..ee10ce8e35b7d8eb8c4a6d3adf16a3a95c28af74 100644

--- a/Source/core/dom/SelectorQuery.cpp

+++ b/Source/core/dom/SelectorQuery.cpp

@@ -122,9 +122,8 @@ inline bool SelectorDataList::selectorMatches(const CSSSelector& selector, Eleme

SelectorChecker selectorChecker(SelectorChecker::QueryingRules);

SelectorChecker::SelectorCheckingContext selectorCheckingContext(&element, SelectorChecker::VisitedMatchDisabled);

selectorCheckingContext.selector = &selector;

- selectorCheckingContext.scope = !rootNode.isDocumentNode() ? &rootNode : nullptr;

- if (selectorCheckingContext.scope)

- selectorCheckingContext.scopeContainsLastMatchedElement = true;

+ selectorCheckingContext.scope = &rootNode;

+ selectorCheckingContext.scopeContainsLastMatchedElement = true;

esprehn 2015/08/29 23:55:30 Why do we need scopeContainsLastMatchedElement at

return selectorChecker.match(selectorCheckingContext);

}

« no previous file with comments | « Source/core/css/SelectorChecker.cpp ('k') | no next file » | no next file with comments »