Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1245873002: Fix sbox_validation_tests & Make isolate_driver.py include the executable itself (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 3 months ago
Reviewers:
stgao, jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, nektar+watch_chromium.org, jdduke+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, dmazzoni+watch_chromium.org, peter+watch_chromium.org, stevenjb+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, toyoshim+midi_chromium.org, aboxhall+watch_chromium.org, ben+mojo_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, pvalenzuela+watch_chromium.org, je_julie, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, erikwright+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, tapted, jasonroberts+watch_google.com, mlamouri+watch-notifications_chromium.org, rickyz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, darin (slow to review), maniscalco+watch_chromium.org, hclam+watch_chromium.org, plundblad+watch_chromium.org, Ian Vollick, tfarina, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, plaree+watch_chromium.org, dtseng+watch_chromium.org, cc-bugs_chromium.org, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2_process
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sbox_validation_tests & Make isolate_driver.py include the executable itself Further reduce the boilerplate in .isolate files and is necessary to add debug symbols, to be done in a follow up. Slightly accelerate ninja file parsing by blacklisting more extensions. sbox_validation_tests wasn't run on Windows since https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL uncovered this copy-paste error. TBR=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c6649f2e014a24a9093140a06fcadcaf2a06513c Cr-Commit-Position: refs/heads/master@{#347027}

Patch Set 1 : . #

Patch Set 2 : Silly me, had forgot .exe #

Patch Set 3 : sbox_validation_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -100 lines) Patch
M ash/ash_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M base/base_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/angle_deqp_gles2_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/angle_end2end_tests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/angle_unittests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chromedriver_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/gl_tests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/gles2_conform_test.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer_util_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/setup_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/unit_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_browsertests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl_loader_unittests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_browsertests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_gl_tests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/courgette_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/crypto_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M device/device_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions_browsertests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/app_shell_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/gcm_unit_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/google_apis_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gpu_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/jingle_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/cast_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M media/media_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M media/midi/midi_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_common_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_js_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M net/net_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/sandbox_linux_unittests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/sandbox_mac_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/sbox_integration_tests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/sbox_unittests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/sbox_validation_tests.isolate View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M skia/skia_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M sql/sql_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sync_unit_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation_unittests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/mojo_public_bindings_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/mojo_public_environment_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/mojo_public_system_unittests.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/mojo_public_utility_unittests.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/gn_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/isolate_driver.py View 1 3 chunks +7 lines, -6 lines 0 comments Download
M ui/accessibility/accessibility_unittests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/app_list_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/aura_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ui_base_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/display_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/events_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/gfx_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_unittests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/message_center/message_center_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/touch_selection/ui_touch_selection_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/wm_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M url/url_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
M-A Ruel
And finally... https://codereview.chromium.org/1245873002/diff/60001/tools/isolate_driver.py is the important diff, the rest is just deleting executables to confirm ...
5 years, 3 months ago (2015-09-02 15:15:55 UTC) #4
M-A Ruel
On 2015/09/02 15:15:55, M-A Ruel wrote: > And finally... > https://codereview.chromium.org/1245873002/diff/60001/tools/isolate_driver.py is > the important ...
5 years, 3 months ago (2015-09-02 15:28:20 UTC) #5
jam
lgtm
5 years, 3 months ago (2015-09-02 17:14:45 UTC) #6
M-A Ruel
On 2015/09/02 17:14:45, jam wrote: > lgtm The bug was trivial, CQ'ing (with TBR due ...
5 years, 3 months ago (2015-09-02 17:23:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245873002/70069 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245873002/70069
5 years, 3 months ago (2015-09-02 17:24:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/102292)
5 years, 3 months ago (2015-09-02 18:20:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245873002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245873002/90001
5 years, 3 months ago (2015-09-02 19:31:13 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/111128)
5 years, 3 months ago (2015-09-02 19:59:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245873002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245873002/90001
5 years, 3 months ago (2015-09-02 20:02:05 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:90001)
5 years, 3 months ago (2015-09-02 21:20:47 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c6649f2e014a24a9093140a06fcadcaf2a06513c Cr-Commit-Position: refs/heads/master@{#347027}
5 years, 3 months ago (2015-09-02 21:21:43 UTC) #21
stgao
Hi Marc, This CL seems causing the compile failure in Linux official build https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/3899 It ...
5 years, 3 months ago (2015-09-02 23:50:41 UTC) #23
stgao
5 years, 3 months ago (2015-09-03 00:11:44 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:90001) has been created in
https://codereview.chromium.org/1329783003/ by stgao@chromium.org.

The reason for reverting is: This CL seems to break compile
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%....

If the revert doesn't fix it, I will re-land this CL..

Powered by Google App Engine
This is Rietveld 408576698