Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1245843003: [CodeHealth] Use Position::anchorNode instead of deprecatedNode. (Closed)

Created:
5 years, 5 months ago by yoichio
Modified:
5 years, 5 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, groby+blinkspell_chromium.org, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CodeHealth] Use Position::anchorNode instead of deprecatedNode. They return same object so simplify code. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -316 lines) Patch
M Source/core/dom/Position.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Position.cpp View 22 chunks +47 lines, -47 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 18 chunks +42 lines, -42 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Caret.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 15 chunks +31 lines, -31 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 14 chunks +38 lines, -38 lines 0 comments Download
M Source/core/editing/DragCaretController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/Editor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 16 chunks +23 lines, -23 lines 0 comments Download
M Source/core/editing/SelectionController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/SpellChecker.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 16 chunks +27 lines, -27 lines 0 comments Download
M Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/page/FocusController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yoichio
5 years, 5 months ago (2015-07-22 06:54:59 UTC) #2
yosin_UTC9
lgtm +tkent@ as OWNERS review
5 years, 5 months ago (2015-07-22 07:39:22 UTC) #4
tkent
rs lgtm
5 years, 5 months ago (2015-07-22 07:50:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245843003/1
5 years, 5 months ago (2015-07-22 08:02:01 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 08:06:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199285

Powered by Google App Engine
This is Rietveld 408576698