Source/core/editing/VisiblePosition.h - Issue 1245843003: [CodeHealth] Use Position::anchorNode instead of deprecatedNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 1245843003: [CodeHealth] Use Position::anchorNode instead of deprecatedNode. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisiblePosition.h

diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h

index ac59299822e81983eb127bc4f73bf35a163ca49b..0b2d20d661b611ece6598bc5793c3056aa476f34 100644

--- a/Source/core/editing/VisiblePosition.h

+++ b/Source/core/editing/VisiblePosition.h

@@ -88,7 +88,7 @@ public:

UChar32 characterBefore() const { return previous().characterAfter(); }

// FIXME: This does not handle [table, 0] correctly.

- Element* rootEditableElement() const { return m_deepPosition.isNotNull() ? m_deepPosition.deprecatedNode()->rootEditableElement() : 0; }

+ Element* rootEditableElement() const { return m_deepPosition.isNotNull() ? m_deepPosition.anchorNode()->rootEditableElement() : 0; }

InlineBoxPosition computeInlineBoxPosition() const

{

« no previous file with comments | « Source/core/editing/StyledMarkupSerializer.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »