runtime/vm/code_generator.cc - Issue 12457034: Ensure that all goto instructions have deoptimization target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator.cc

Issue 12457034: Ensure that all goto instructions have deoptimization target. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address Florian's comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator.cc

diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc

index daafa59723152620853211a0b3dd23ccad6eef42..624ace99dfc9e06f3f76cf8e8bdec9e59ac72695 100644

--- a/runtime/vm/code_generator.cc

+++ b/runtime/vm/code_generator.cc

@@ -576,6 +576,8 @@ DEFINE_RUNTIME_ENTRY(Instanceof, 5) {

instance, type, instantiator_type_arguments, result);

}

if (!result.value() && !malformed_error.IsNull()) {

+ UNREACHABLE();

Florian Schneider 2013/04/12 11:01:52 Accidental edit?

Vyacheslav Egorov (Google) 2013/04/12 11:02:48 Indeed. Reverted.

// Throw a dynamic type error only if the instanceof test fails.

const intptr_t location = GetCallerLocation();

String& malformed_error_message = String::Handle(

« no previous file with comments | « no previous file | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »