Ensure that all goto instructions have deoptimization target.

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 558 matching lines @@
   Error& malformed_error = Error::Handle();
   const Bool& result =
       instance.IsInstanceOf(type,
                             instantiator_type_arguments,
                             &malformed_error) ? Bool::True() : Bool::False();
   if (FLAG_trace_type_checks) {
     PrintTypeCheck("InstanceOf",
         instance, type, instantiator_type_arguments, result);
   }
   if (!result.value() && !malformed_error.IsNull()) {
+    UNREACHABLE();

[Florian Schneider, 2013/04/12 11:01:52]

Accidental edit?

[Vyacheslav Egorov (Google), 2013/04/12 11:02:48]

Indeed. Reverted.

+
     // Throw a dynamic type error only if the instanceof test fails.
     const intptr_t location = GetCallerLocation();
     String& malformed_error_message =  String::Handle(
         String::New(malformed_error.ToErrorCString()));
     Exceptions::CreateAndThrowTypeError(
         location, Symbols::Empty(), Symbols::Empty(),
         Symbols::Empty(), malformed_error_message);
     UNREACHABLE();
   }
   UpdateTypeTestCache(instance, type, instantiator,
@@ skipping 1130 matching lines @@
 //   Arg1: Value that is being stored.
 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
   ASSERT(arguments.ArgCount() == kUpdateFieldCidRuntimeEntry.argument_count());
   const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
   const Object& value = Object::Handle(arguments.ArgAt(1));
 
   field.UpdateCid(Class::Handle(value.clazz()).id());
 }
 
 }  // namespace dart